From: Jyrki Gadinger <nilsding@nilsding.org>
Date: Thu, 24 Jul 2025 14:05:18 +0000 (+0200)
Subject: perf(activitylistmodel): avoid creation of temporary Activity objects
X-Git-Tag: archive/raspbian/3.16.7-1_deb13u1+rpi1^2~13^2^2~3^2~1
X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=82990dee36f82267038a232e1d3ec67779a65393;p=nextcloud-desktop.git

perf(activitylistmodel): avoid creation of temporary Activity objects

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
---

diff --git a/src/gui/tray/activitylistmodel.cpp b/src/gui/tray/activitylistmodel.cpp
index 4a4f3f807..554559b16 100644
--- a/src/gui/tray/activitylistmodel.cpp
+++ b/src/gui/tray/activitylistmodel.cpp
@@ -543,7 +543,7 @@ void ActivityListModel::addEntriesToActivityList(const ActivityList &activityLis
     }
     endInsertRows();
 
-    const auto deselectedConflictIt = std::find_if(_finalList.constBegin(), _finalList.constEnd(), [] (const auto activity) {
+    const auto deselectedConflictIt = std::find_if(_finalList.constBegin(), _finalList.constEnd(), [] (const auto &activity) {
         return activity._syncFileItemStatus == SyncFileItem::Conflict;
     });
     const auto conflictsFound = (deselectedConflictIt != _finalList.constEnd());